Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use activeAccount addr in profile link #2320

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: use activeAccount addr in profile link #2320

merged 1 commit into from
Mar 18, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Mar 12, 2024 •
edited
Loading

Description

Closes: regen-network/rnd-dev-team#1869

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

From https://deploy-preview-2320--regen-marketplace.netlify.app/

  1. Log in with Keplr wallet addr A
  2. Switch to wallet addr B from Keplr, and do not accept the "prove ownership" popup, just close it
  3. Copy link to your profile from your profile page, this should have the right addr in it (addr A)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited
Loading

✅ Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit fd98200
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/65f8131580dda4000822ee24
😎 Deploy Preview https://deploy-preview-2320--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from a team March 12, 2024 11:52
@blushi
Copy link
Member Author

blushi commented Mar 12, 2024

@erikalogie see testing instructions

@erikalogie
Copy link
Collaborator

erikalogie commented Mar 12, 2024 •
edited
Loading

@blushi this looks good, just noting here that I again had the issue with not seeing all the tabs in the dropdown or on the profile page:
Screen Shot 2024-03-12 at 9 14 11 AM

@blushi
Copy link
Member Author

blushi commented Mar 13, 2024

@blushi this looks good, just noting here that I again had the issue with not seeing all the tabs in the dropdown or on the profile page: Screen Shot 2024-03-12 at 9 14 11 AM

Yeah as discussed on slack, I've created a separate issue for that #2322

@erikalogie
Copy link
Collaborator

@blushi this looks good, just noting here that I again had the issue with not seeing all the tabs in the dropdown or on the profile page: Screen Shot 2024-03-12 at 9 14 11 AM

Yeah as discussed on slack, I've created a separate issue for that #2322

Ok perfect, this is good then!

@blushi blushi enabled auto-merge (squash) March 18, 2024 10:10
@blushi blushi merged commit cc7dc4f into dev Mar 18, 2024
2 checks passed
@blushi blushi deleted the fix-1869-profile-link branch March 18, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Portfolio and regen address is showing on web 2.0 public profile page
3 participants
@blushi @erikalogie @aaronc